[ https://issues.apache.org/jira/browse/HIVE-22402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959974#comment-16959974 ]
Hive QA commented on HIVE-22402: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12984032/HIVE-22402.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 188 failed/errored test(s), 17545 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=291) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=291) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=291) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=299) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_insert_overwrite] (batchId=54) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_join] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_nullscan] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats2] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats3] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats4] (batchId=68) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats5] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_subquery] (batchId=44) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_table_directories_test] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_table_stats] (batchId=59) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_vectorization] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_vectorization_partition] (batchId=80) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_vectorization_project] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_view_delete] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_delete] (batchId=92) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_delete_own_table] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_update] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_update_own_table] (batchId=86) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_4] (batchId=14) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_transactional_full_acid] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_all_non_partitioned] (batchId=32) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_all_partitioned] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_tmp_table] (batchId=57) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_where_no_match] (batchId=32) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_where_non_partitioned] (batchId=43) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_where_partitioned] (batchId=44) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[delete_whole_partition] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_acid_dynamic_partition] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_nonacid_from_acid] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_update_delete] (batchId=95) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_dynamic_partitioned] (batchId=84) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_non_partitioned] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_partitioned] (batchId=84) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_tmp_table] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[llap_reader] (batchId=8) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_acid_no_masking] (batchId=26) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_mv] (batchId=90) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[materialized_view_create_acid] (batchId=73) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_all] (batchId=75) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_buckets] (batchId=66) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_insert_overwrite_aborted] (batchId=89) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nullability_transitive_inference] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_exception] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[repl_load_old_version] (batchId=25) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=87) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_nonpart] (batchId=14) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_part2] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[symlink_text_input_format] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[transform_acid] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_after_multiple_inserts] (batchId=76) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_after_multiple_inserts_special_characters] (batchId=81) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_all_non_partitioned] (batchId=8) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_all_partitioned] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_all_types] (batchId=19) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_orig_table] (batchId=68) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_tmp_table] (batchId=40) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_two_cols] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_where_no_match] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_where_non_partitioned] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_where_partitioned] (batchId=69) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_acid3] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char] (batchId=25) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_insert_partition_dynamic] (batchId=191) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_insert_partition_static] (batchId=188) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[external_table_ppd] (batchId=105) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_binary_external_table_queries] (batchId=108) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_binary_map_queries] (batchId=109) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_binary_map_queries_prefix] (batchId=107) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_binary_storage_queries] (batchId=108) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_handler_snapshot] (batchId=108) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_joins] (batchId=110) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_null_first_col] (batchId=105) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_ppd_join] (batchId=107) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_ppd_key_range] (batchId=106) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_pushdown] (batchId=106) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_queries] (batchId=107) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_single_sourced_multi_insert] (batchId=109) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_timestamp] (batchId=108) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_viewjoins] (batchId=106) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbasestats] (batchId=106) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[ppd_key_ranges] (batchId=105) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[masking_mv] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[materialized_view_no_cbo_rewrite_2] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[materialized_view_no_supported_op_rewrite_2] (batchId=103) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[merge_constraint_notnull] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[mm_delete] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[mm_update] (batchId=101) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[strict_pruning_2] (batchId=102) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=344) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testCombinationInputFormatWithAcid (batchId=325) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testLoadData (batchId=353) org.apache.hadoop.hive.ql.parse.TestMetaStoreEventListenerInRepl.testReplEvents (batchId=275) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.retryIncBootstrapAcidFromDifferentDumpWithoutCleanTablesConfig (batchId=252) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testAcidTablesBootstrapDuringIncremental (batchId=252) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testAcidTablesBootstrapDuringIncrementalWithOpenTxnsTimeout (batchId=252) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites (batchId=252) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testRetryAcidTablesBootstrapFromDifferentDump (batchId=252) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidBootstrapReplLoadRetryAfterFailure (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrap (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentDropTable (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentWrites (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithOpenTxnsTimeout (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationBootStrap (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationIncremental (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testMultiDBTxn (batchId=269) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testBootstrapLoadMigrationManagedToAcid (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testBootstrapLoadMigrationToAcidWithMoveOptimization (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcid (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcidAllOp (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcidFailure (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcidFailurePart (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationToAcidWithMoveOptimization (batchId=267) org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingDynamicPartitionWithTxnBatchSizeAsOne (batchId=249) org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingStaticPartitionWithTxnBatchSizeAsOne (batchId=249) org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingUnpartitionedWithTxnBatchSizeAsOne (batchId=249) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidBootstrapReplLoadRetryAfterFailure (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrap (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithConcurrentDropTable (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithConcurrentWrites (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithOpenTxnsTimeout (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesMoveOptimizationBootStrap (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesMoveOptimizationIncremental (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testMultiDBTxn (batchId=271) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.retryIncBootstrapAcidFromDifferentDumpWithoutCleanTablesConfig (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.testAcidTablesBootstrapDuringIncremental (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.testAcidTablesBootstrapDuringIncrementalWithOpenTxnsTimeout (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.testRetryAcidTablesBootstrapFromDifferentDump (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosIncrementalLoadAcidTables.testAcidTableIncrementalReplication (batchId=272) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosIncrementalLoadAcidTables.testReplCM (batchId=272) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testBootstrapLoadMigrationManagedToAcid (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testBootstrapLoadMigrationToAcidWithMoveOptimization (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcid (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcidAllOp (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcidFailure (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcidFailurePart (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationToAcidWithMoveOptimization (batchId=256) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigrationEx.testConcurrentOpDuringBootStrapDumpCreateTableReplay (batchId=266) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigrationEx.testConcurrentOpDuringBootStrapDumpInsertOverwrite (batchId=266) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigrationEx.testConcurrentOpDuringBootStrapDumpInsertReplay (batchId=266) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigrationEx.testIncLoadPenFlagPropAlterDB (batchId=266) org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigrationEx.testIncLoadPenFlagWithMoveOptimization (batchId=266) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID.testForParallelBootstrapLoad (batchId=254) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID.testMetadataOnlyDump (batchId=254) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID.testNonParallelBootstrapLoad (batchId=254) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID.testRetryFailure (batchId=254) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACIDNoAutogather.testForParallelBootstrapLoad (batchId=255) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACIDNoAutogather.testMetadataOnlyDump (batchId=255) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACIDNoAutogather.testNonParallelBootstrapLoad (batchId=255) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACIDNoAutogather.testRetryFailure (batchId=255) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMM.testForParallelBootstrapLoad (batchId=259) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMM.testMetadataOnlyDump (batchId=259) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMM.testNonParallelBootstrapLoad (batchId=259) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMM.testRetryFailure (batchId=259) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testForParallelBootstrapLoad (batchId=251) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testMetadataOnlyDump (batchId=251) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testNonParallelBootstrapLoad (batchId=251) org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testRetryFailure (batchId=251) org.apache.hive.hcatalog.streaming.TestStreaming.testBucketingWhereBucketColIsNotFirstCol (batchId=219) org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits (batchId=219) org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits (batchId=219) org.apache.hive.hcatalog.streaming.TestStreaming.testNoBuckets (batchId=219) org.apache.hive.jdbc.TestJdbcDriver2.testExceucteUpdateCounts (batchId=285) org.apache.hive.service.server.TestInformationSchemaWithPrivilege.test (batchId=282) org.apache.hive.streaming.TestStreaming.testAllTypesDelimitedWriter (batchId=361) org.apache.hive.streaming.TestStreaming.testAllTypesDelimitedWriterInputStream (batchId=361) org.apache.hive.streaming.TestStreaming.testAutoRollTransactionBatch (batchId=361) org.apache.hive.streaming.TestStreaming.testBucketingWhereBucketColIsNotFirstCol (batchId=361) org.apache.hive.streaming.TestStreaming.testCommitWithKeyValue (batchId=361) org.apache.hive.streaming.TestStreaming.testConnectionWithWriteId (batchId=361) org.apache.hive.streaming.TestStreaming.testInterleavedTransactionBatchCommits (batchId=361) org.apache.hive.streaming.TestStreaming.testMultipleTransactionBatchCommits (batchId=361) org.apache.hive.streaming.TestStreaming.testNoBuckets (batchId=361) org.apache.hive.streaming.TestStreaming.testStreamBucketingMatchesRegularBucketing (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPStreamBucketingMatchesRegularBucketing (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevel (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevelMissingPartitionValues (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevelNonStringPartitionColumns (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testJsonInputStreamDP (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testRegexInputStreamDP (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteAfterAbort (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteAfterClose (batchId=361) org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteBeforeBegin (batchId=361) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19160/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19160/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19160/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 188 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12984032 - PreCommit-HIVE-Build > Deprecate Hive PerfLogger > ------------------------- > > Key: HIVE-22402 > URL: https://issues.apache.org/jira/browse/HIVE-22402 > Project: Hive > Issue Type: Improvement > Affects Versions: 4.0.0 > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-22402.1.patch > > > Recently I wanted to add some additional capability, and add more, > performance logging to support my troubleshooting efforts. I started looking > at PerfLogger and started to examine its usage. I discovered a few things: > # Since 'loggers' must be open and closed manually, I found a couple of > places where loggers were opened, but not closed, rendering them useless > # Since 'loggers' must be closed manually, I found a few places where an > early-return or Exception thrown would cause a logger to not be closed, > thereby rendering it useless > # Session information is not logged, so it can be difficult to precisely > pinpoint which session is taking lots of time > # PerfLogger overloaded. Most of the time, it's being used as a simple timer > mechanism with automatic logging in SLF4J debug. However, it is also a facade > over the Hive Metrics subsystem and timing results are automatically > published to Metrics and then there becomes this dependency on a 'logger' to > be able to access metric data as well. > The last bullet is the most challenging part and why I propose to deprecate > the Hive {{PerfLogger}} and not simply remove it. I am proposing a new > system... a {{PerfTimer}} that is allows for Java 8's try-with-resources > feature to protect against the developer having to care about manually close > measurements and not having to carefully consider all early-exits. The base > implementation logs to SLF4J. An extended version automatically publishes to > the Hive Metric subsystem as well. > The Hive {{PerfLogger}} has a bit of a clunky system for allowing plugable > implementations. However, there are sections of the code that rely on the > {{PerfLogger}}'s ability to publish to the Metrics subsystem. These code > section look up various timers in the Metrics Subsytem and publish the > results back to the client. Since, in theory, the implementation is plugable, > any other implementation that does not publish to the Metrics Subsystem will > break these code paths. Also, these code paths create and interact with > {{PerfLoggers in a static way, and then the publishing code pulls the data > from the {{PerfLogger}}}} (as a facade to the Metrics subsystem) in a static > way. Therefore, when I tried to replace the entire {{PerfLogger}} code, I > came across an issue because there is not (and should not) be a way to just > statically pull this information down from any point in the code. Information > that is required for publishing should be passed around within some sort of > context object, separate from the Metrics subsystem. There was no obvious way > to string a new {{PerfTimer}} to all the required locations. I propose > marking the {{PerfLogger}} as deprecated and leaving these complex section > alone. Instead, replace only the simple "I want a timer" use cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)