[ https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=342163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342163 ]
ASF GitHub Bot logged work on HIVE-21198: ----------------------------------------- Author: ASF GitHub Bot Created on: 12/Nov/19 21:21 Start Date: 12/Nov/19 21:21 Worklog Time Spent: 10m Work Description: kgyrtkirk commented on pull request #550: HIVE-21198 Introduce a database object reference class URL: https://github.com/apache/hive/pull/550#discussion_r345443647 ########## File path: ql/src/test/results/clientnegative/delete_non_acid_table.q.out ########## @@ -34,4 +34,4 @@ POSTHOOK: Input: default@not_an_acid_table2 -1070883071 0ruyd6Y50JpdGRf6HqD -1070551679 iUR3Q -1069736047 k17Am8uPHWk02cEf1jet -FAILED: SemanticException [Error 10297]: Attempt to do update or delete on table default.not_an_acid_table2 that is not transactional +FAILED: SemanticException [Error 10297]: Attempt to do update or delete on table not_an_acid_table2 that is not transactional Review comment: we are loosing the qualified database name from the exception; I think this should be made consistent; to show it everywhere - I'm not sure about if we should be also showing the catalog name or not... but if we do; we should "try" to be consistent about that as well ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 342163) Time Spent: 3h 40m (was: 3.5h) > Introduce a database object reference class > ------------------------------------------- > > Key: HIVE-21198 > URL: https://issues.apache.org/jira/browse/HIVE-21198 > Project: Hive > Issue Type: Sub-task > Reporter: Zoltan Haindrich > Assignee: David Lavati > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch, > HIVE-21198.11.patch, HIVE-21198.2.patch, HIVE-21198.3.patch, > HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch, > HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch > > Time Spent: 3h 40m > Remaining Estimate: 0h > > There are many places in which "{databasename}.{tablename}" is passed as a > single string; there are some places where the they travel as 2 separate > arguments. > Idea would be to introduce a simple immutable class with 2 fields ; and pass > these informations together. Making this better is required if we would be > wanting to enable dot in tablenames > HIVE-16907, HIVE-21151 -- This message was sent by Atlassian Jira (v8.3.4#803005)