[
https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=342165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342165
]
ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 21:21
Start Date: 12/Nov/19 21:21
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #550: HIVE-21198
Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345449867
##########
File path: storage-api/src/java/org/apache/hadoop/hive/common/TableName.java
##########
@@ -86,36 +101,55 @@ public String getTable() {
/**
* Get the name in db.table format, for use with stuff not yet converted to
use the catalog.
+ * Fair warning, that if the db is null, this will return null.tableName
+ * @deprecated use {@link #getNotEmptyDbTable()} instead.
*/
+ // to be @Deprecated
public String getDbTable() {
return db + DatabaseName.CAT_DB_TABLE_SEPARATOR + table;
+ }
+
+ /**
+ * Get the name in `db`.`table` escaped format, if db is not empty,
otherwise pass only the table name.
+ */
+ public String getEscapedNotEmptyDbTable() {
Review comment:
I think these escaper things should live in the exec side; aren't they only
used during unparsing around there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 342165)
> Introduce a database object reference class
> -------------------------------------------
>
> Key: HIVE-21198
> URL: https://issues.apache.org/jira/browse/HIVE-21198
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch,
> HIVE-21198.11.patch, HIVE-21198.2.patch, HIVE-21198.3.patch,
> HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch,
> HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a
> single string; there are some places where the they travel as 2 separate
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would be
> wanting to enable dot in tablenames
> HIVE-16907, HIVE-21151
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
