[
https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=404840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404840
]
ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 16:25
Start Date: 17/Mar/20 16:25
Worklog Time Spent: 10m
Work Description: aasha commented on pull request #949: HIVE-22990 Add
file based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393806962
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -398,6 +319,21 @@ private void dropTablesExcludedInReplScope(ReplScope
replScope) throws HiveExcep
dbName);
}
+ private void createReplLoadCompleteAckTask() {
+ if ((work.isIncrementalLoad() &&
!work.incrementalLoadTasksBuilder().hasMoreWork() &&
!work.hasBootstrapLoadTasks())
+ || (!work.isIncrementalLoad() && !work.hasBootstrapLoadTasks())) {
+ //All repl load tasks are executed and status is 0, create the task to
add the acknowledgement
+ ReplLoadCompleteAckWork replLoadCompleteAckWork = new
ReplLoadCompleteAckWork(work.dumpDirectory);
+ Task<ReplLoadCompleteAckWork> loadCompleteAckWorkTask =
TaskFactory.get(replLoadCompleteAckWork, conf);
+ if (this.childTasks.isEmpty()) {
Review comment:
No. Its initialised at line 440 for incremental and 86 for bootstrap before
this method is called
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 404840)
Time Spent: 5h (was: 4h 50m)
> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
> Key: HIVE-22990
> URL: https://issues.apache.org/jira/browse/HIVE-22990
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch,
> HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch,
> HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch,
> HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch,
> HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
> HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch,
> HIVE-22990.18.patch, HIVE-22990.19.patch, HIVE-22990.20.patch,
> HIVE-22990.21.patch, HIVE-22990.22.patch, HIVE-22990.patch
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
