[ https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=405114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405114 ]
ASF GitHub Bot logged work on HIVE-22990: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Mar/20 01:48 Start Date: 18/Mar/20 01:48 Worklog Time Spent: 10m Work Description: aasha commented on pull request #949: HIVE-22990 Add file based ack for replication URL: https://github.com/apache/hive/pull/949#discussion_r394056775 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java ########## @@ -398,6 +319,21 @@ private void dropTablesExcludedInReplScope(ReplScope replScope) throws HiveExcep dbName); } + private void createReplLoadCompleteAckTask() { + if ((work.isIncrementalLoad() && !work.incrementalLoadTasksBuilder().hasMoreWork() && !work.hasBootstrapLoadTasks()) Review comment: The external table tasks are already added before this method is called. But have still added the check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 405114) Time Spent: 5h 40m (was: 5.5h) > Build acknowledgement mechanism for repl dump and load > ------------------------------------------------------ > > Key: HIVE-22990 > URL: https://issues.apache.org/jira/browse/HIVE-22990 > Project: Hive > Issue Type: Bug > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch, > HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch, > HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch, > HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch, > HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch, > HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch, > HIVE-22990.18.patch, HIVE-22990.19.patch, HIVE-22990.20.patch, > HIVE-22990.21.patch, HIVE-22990.22.patch, HIVE-22990.23.patch, > HIVE-22990.24.patch, HIVE-22990.patch > > Time Spent: 5h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)