[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097728#comment-17097728
]
Hive QA commented on HIVE-23215:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
52s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
23s{color} | {color:blue} storage-api in master has 51 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
46s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} storage-api: The patch generated 0 new + 11
unchanged - 3 fixed = 11 total (was 14) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} The patch ql passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} storage-api generated 4 new + 46 unchanged - 5 fixed =
50 total (was 51) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:storage-api |
| | org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.getSelected()
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 373] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.updateSelected(int)
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 406] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setFilterContext(boolean,
int[], int) may expose internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 384] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setSelected(int[]) may
expose internal representation by storing an externally mutable object into
VectorizedRowBatch.selected At VectorizedRowBatch.java:by storing an
externally mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 416] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-22064/dev-support/hive-personality.sh
|
| git revision | master / cdd55aa |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-22064/yetus/new-findbugs-storage-api.html
|
| modules | C: storage-api ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-22064/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Make FilterContext and MutableFilterContext interfaces
> ------------------------------------------------------
>
> Key: HIVE-23215
> URL: https://issues.apache.org/jira/browse/HIVE-23215
> Project: Hive
> Issue Type: Bug
> Components: storage-api
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23215.01.patch, HIVE-23215.02.patch,
> HIVE-23215.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HIVE-22959 introduced FilterContext to support ORC-577. The duplication of
> fields between the FilterContext and VectorizedRowBatch seems likely to cause
> user confusion. This patch makes them interfaces that VectorizedRowBatch
> implements.
> Thus, there is a single copy of the data and no need to copy them back and
> forth. LLAP can make its own implementation of the interfaces if it doesn't
> want to use VectorizedRowBatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
