[ 
https://issues.apache.org/jira/browse/HIVE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109913#comment-17109913
 ] 

Ashutosh Chauhan commented on HIVE-23281:
-----------------------------------------

This patch fixes following from original patch:
a) Compiler was always looking for skewed col info, even when its not needed 
and not returned from metastore which was causing NPE
b) Bucket cols are needed for Acid tables, since Acid tables could be bucketed. 
Was causing failures.
c) We need to also implement JDO path necessarily since tests are run to make 
sure results are identical from two. Not having it implemented caused test 
fails. 

> ObjectStore::convertToStorageDescriptor can be optimised to reduce calls to 
> DB for ACID tables
> ----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-23281
>                 URL: https://issues.apache.org/jira/browse/HIVE-23281
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Ramesh Kumar Thangarajan
>            Priority: Major
>         Attachments: HIVE-23281.1.patch, HIVE-23281.2.patch, 
> image-2020-04-23-13-56-17-210.png
>
>
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1980]
>  
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1982]
>  
> SkewInfo, bucketCols, ordering etc are not needed for ACID tables. It may be 
> good to check for transactional tables and get rid these calls in table 
> lookups.
>  
> This should help in reducing DB calls.
> !image-2020-04-23-13-56-17-210.png|width=669,height=485!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to