[
https://issues.apache.org/jira/browse/HIVE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109948#comment-17109948
]
Hive QA commented on HIVE-23281:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003247/HIVE-23281.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22428/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22428/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22428/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-05-18 06:54:44.443
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-22428/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-05-18 06:54:44.446
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 28bdeeb HIVE-23476 : LLAP: Preallocate arenas for mmap case as
well (Prasanth J via Gopal V)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 28bdeeb HIVE-23476 : LLAP: Preallocate arenas for mmap case as
well (Prasanth J via Gopal V)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-05-18 06:54:45.477
+ rm -rf ../yetus_PreCommit-HIVE-Build-22428
+ mkdir ../yetus_PreCommit-HIVE-Build-22428
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-22428
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-22428/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
does not exist in index
error: a/ql/src/test/results/clientpositive/llap/acid_nullscan.q.out: does not
exist in index
error:
a/ql/src/test/results/clientpositive/llap/acid_table_directories_test.q.out:
does not exist in index
error:
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
does not exist in index
error:
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
does not exist in index
Trying to apply the patch with -p1
error: patch failed:
ql/src/test/results/clientpositive/llap/acid_nullscan.q.out:91
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/llap/acid_nullscan.q.out'
with conflicts.
Going to apply patch with: git apply -p1
error: patch failed:
ql/src/test/results/clientpositive/llap/acid_nullscan.q.out:91
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/llap/acid_nullscan.q.out'
with conflicts.
U ql/src/test/results/clientpositive/llap/acid_nullscan.q.out
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-22428
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13003247 - PreCommit-HIVE-Build
> ObjectStore::convertToStorageDescriptor can be optimised to reduce calls to
> DB for ACID tables
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-23281
> URL: https://issues.apache.org/jira/browse/HIVE-23281
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Attachments: HIVE-23281.1.patch, HIVE-23281.2.patch,
> image-2020-04-23-13-56-17-210.png
>
>
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1980]
>
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1982]
>
> SkewInfo, bucketCols, ordering etc are not needed for ACID tables. It may be
> good to check for transactional tables and get rid these calls in table
> lookups.
>
> This should help in reducing DB calls.
> !image-2020-04-23-13-56-17-210.png|width=669,height=485!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
