[
https://issues.apache.org/jira/browse/HIVE-23965?focusedWorklogId=511305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511305
]
ASF GitHub Bot logged work on HIVE-23965:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/20 10:44
Start Date: 13/Nov/20 10:44
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1347:
URL: https://github.com/apache/hive/pull/1347#discussion_r522870090
##########
File path:
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestTezTPCDS30TBPerfCliDriver.java
##########
@@ -17,30 +17,32 @@
*/
package org.apache.hadoop.hive.cli;
-import java.io.File;
-import java.util.Comparator;
-import java.util.List;
-
import org.apache.hadoop.hive.cli.control.CliAdapter;
import org.apache.hadoop.hive.cli.control.CliConfigs;
+import org.apache.hadoop.hive.cli.control.SplitSupport;
import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestRule;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
+import org.junit.runners.model.Statement;
+
+import java.io.File;
+import java.util.Comparator;
+import java.util.List;
@RunWith(Parameterized.class)
-public class TestTezPerfCliDriver {
+public class TestTezTPCDS30TBPerfCliDriver {
- static CliAdapter adapter = new
CliConfigs.TezPerfCliConfig(false).getCliAdapter();
+ static CliAdapter adapter = new
CliConfigs.TezTPCDS30TBCliConfig().getCliAdapter();
@Parameters(name = "{0}")
public static List<Object[]> getParameters() throws Exception {
List<Object[]> parameters = adapter.getParameters();
parameters.sort(new C1());
- return parameters;
+ return SplitSupport.process(parameters,
TestTezTPCDS30TBPerfCliDriver.class, 10);
Review comment:
20 minutes is also fine...we have quite a few [replication tests above
30 minutes right
now](http://ci.hive.apache.org/job/hive-precommit/job/master/337/testReport/org.apache.hadoop.hive.ql.parse/)
note that in its current form it would not work because you need to have a
separated "N_SPLITS" integer in the class source(like in other clidriver
classes) for the splitter to work.
I think we can leave this out for now - 10 splits is a bit too many for a 20
minute test (2 or 3 would fit better)
in case of this test there is a bit more overhead per execution; because it
will probably need to download and launch the metastore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 511305)
Time Spent: 2h 10m (was: 2h)
> Improve plan regression tests using TPCDS30TB metastore dump and custom
> configs
> -------------------------------------------------------------------------------
>
> Key: HIVE-23965
> URL: https://issues.apache.org/jira/browse/HIVE-23965
> Project: Hive
> Issue Type: Improvement
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The existing regression tests (HIVE-12586) based on TPC-DS have certain
> shortcomings:
> The table statistics do not reflect cardinalities from a specific TPC-DS
> scale factor (SF). Some tables are from a 30TB dataset, others from 200GB
> dataset, and others from a 3GB dataset. This mix leads to plans that may
> never appear when using an actual TPC-DS dataset.
> The existing statistics do not contain information about partitions something
> that can have a big impact on the resulting plans.
> The existing regression tests rely on more or less on the default
> configuration (hive-site.xml). In real-life scenarios though some of the
> configurations differ and may impact the choices of the optimizer.
> This issue aims to address the above shortcomings by using a curated
> TPCDS30TB metastore dump along with some custom hive configurations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
