[
https://issues.apache.org/jira/browse/HIVE-23965?focusedWorklogId=512842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512842
]
ASF GitHub Bot logged work on HIVE-23965:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/20 11:28
Start Date: 17/Nov/20 11:28
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #1347:
URL: https://github.com/apache/hive/pull/1347#discussion_r525082746
##########
File path:
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestTezTPCDS30TBPerfCliDriver.java
##########
@@ -56,12 +58,22 @@ public int compare(Object[] o1, Object[] o2) {
public static TestRule cliClassRule = adapter.buildClassRule();
@Rule
- public TestRule cliTestRule = adapter.buildTestRule();
+ public TestRule cliTestRule = (statement, description) -> new Statement() {
Review comment:
It is necessary to keep the rule. I added some clarifications in
https://github.com/apache/hive/pull/1347/commits/4aea9c4311c7c4c4b9b57decf4cb9db1137ff9d9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 512842)
Time Spent: 3h 50m (was: 3h 40m)
> Improve plan regression tests using TPCDS30TB metastore dump and custom
> configs
> -------------------------------------------------------------------------------
>
> Key: HIVE-23965
> URL: https://issues.apache.org/jira/browse/HIVE-23965
> Project: Hive
> Issue Type: Improvement
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The existing regression tests (HIVE-12586) based on TPC-DS have certain
> shortcomings:
> The table statistics do not reflect cardinalities from a specific TPC-DS
> scale factor (SF). Some tables are from a 30TB dataset, others from 200GB
> dataset, and others from a 3GB dataset. This mix leads to plans that may
> never appear when using an actual TPC-DS dataset.
> The existing statistics do not contain information about partitions something
> that can have a big impact on the resulting plans.
> The existing regression tests rely on more or less on the default
> configuration (hive-site.xml). In real-life scenarios though some of the
> configurations differ and may impact the choices of the optimizer.
> This issue aims to address the above shortcomings by using a curated
> TPCDS30TB metastore dump along with some custom hive configurations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
