[
https://issues.apache.org/jira/browse/HIVE-23571?focusedWorklogId=603881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-603881
]
ASF GitHub Bot logged work on HIVE-23571:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/21 08:17
Start Date: 30/May/21 08:17
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r642039659
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -1266,7 +1309,7 @@ public Table getTable(String catName, String dbName,
String tblName, String vali
catName = normalizeIdentifier(catName);
dbName = StringUtils.normalizeIdentifier(dbName);
tblName = StringUtils.normalizeIdentifier(tblName);
- if (!shouldCacheTable(catName, dbName, tblName) || (canUseEvents &&
rawStore.isActiveTransaction())) {
+ if (shouldGetTableFromRawStore(catName, dbName, tblName, validWriteIds)) {
Review comment:
I will do that in new PR. Where I will put tableId and writeId check on
all the methods in cacheStore. This PR is mostly around adding validWriteIdList
to TableWrapper Object in cacheStore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 603881)
Time Spent: 2h 20m (was: 2h 10m)
> [CachedStore] Add ValidWriteIdList to SharedCache.TableWrapper
> --------------------------------------------------------------
>
> Key: HIVE-23571
> URL: https://issues.apache.org/jira/browse/HIVE-23571
> Project: Hive
> Issue Type: Sub-task
> Reporter: Kishen Das
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Add ValidWriteIdList to SharedCache.TableWrapper. This would be used in
> deciding whether a given read request can be served from the cache or we have
> to reload it from the backing database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
