[
https://issues.apache.org/jira/browse/HIVE-23571?focusedWorklogId=603887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-603887
]
ASF GitHub Bot logged work on HIVE-23571:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/21 08:35
Start Date: 30/May/21 08:35
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r642041716
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -918,6 +938,29 @@ private void updateAllTableConstraints(RawStore rawStore,
String catName, String
}
}
+ private void updateValidWriteIdList(TxnStore txnStore, String catName,
String dbName, String tblName) {
+ catName = StringUtils.normalizeIdentifier(catName);
+ dbName = StringUtils.normalizeIdentifier(dbName);
+ tblName = StringUtils.normalizeIdentifier(tblName);
+ LOG.debug("CachedStore: updating cached table validWriteIdlist for
catalog: {}, database: {}, table: {}", catName,
+ dbName, tblName);
+ ValidWriteIdList validWriteIdList = null;
+ try {
+ Deadline.startTimer("getValidWriteIds");
+ validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(txnStore.getValidWriteIds(
+ new
GetValidWriteIdsRequest(Collections.singletonList(TableName.getDbTable(dbName,
tblName))))
+ .getTblValidWriteIds().get(0));
+ Deadline.stopTimer();
+ } catch (Exception e) {
+ LOG.info("Updating CachedStore: unable to update table
validWriteIdList of catalog: " + catName + ", database: "
+ + dbName + ", table: " + tblName, e);
+ }
+ if (validWriteIdList != null) {
+ sharedCache.refreshValidWriteIdListInCache(catName, dbName, tblName,
validWriteIdList);
+ LOG.debug("CachedStore: updated cached table validWriteIdList for
catalog: {}, database: {}, table: {}",
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 603887)
Time Spent: 3h 10m (was: 3h)
> [CachedStore] Add ValidWriteIdList to SharedCache.TableWrapper
> --------------------------------------------------------------
>
> Key: HIVE-23571
> URL: https://issues.apache.org/jira/browse/HIVE-23571
> Project: Hive
> Issue Type: Sub-task
> Reporter: Kishen Das
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Add ValidWriteIdList to SharedCache.TableWrapper. This would be used in
> deciding whether a given read request can be served from the cache or we have
> to reload it from the backing database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
