[
https://issues.apache.org/jira/browse/HIVE-25208?focusedWorklogId=609506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609506
]
ASF GitHub Bot logged work on HIVE-25208:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 07:21
Start Date: 10/Jun/21 07:21
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2359:
URL: https://github.com/apache/hive/pull/2359#discussion_r648916479
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -265,6 +273,28 @@ public String getFileFormatPropertyKey() {
return TableProperties.DEFAULT_FILE_FORMAT;
}
+ @Override
+ public boolean useNativeCommit() {
+ return true;
+ }
+
+ @Override
+ public void nativeCommit(Properties commitProperties, boolean overwrite)
throws HiveException {
+ String tableName = commitProperties.getProperty(Catalogs.NAME);
+ Configuration configuration = SessionState.getSessionConf();
+ Optional<JobContext> jobContext =
getJobContextForCommitOrAbort(configuration, tableName, overwrite);
+ if (jobContext.isPresent()) {
+ try {
+ OutputCommitter committer = new HiveIcebergOutputCommitter();
+ committer.commitJob(jobContext.get());
+ } catch (Throwable e) {
+ LOG.error("Error while trying to commit job, starting rollback", e);
+ rollbackInsertTable(configuration, tableName, overwrite);
+ throw new HiveException("Error committing job", e);
Review comment:
Might be worth including the jobID and tableName into the exception
message here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 609506)
Time Spent: 0.5h (was: 20m)
> Refactor Iceberg commit to the MoveTask/MoveWork
> ------------------------------------------------
>
> Key: HIVE-25208
> URL: https://issues.apache.org/jira/browse/HIVE-25208
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Instead of committing Iceberg changes in `DefaultMetaHook.preCommitInsert` we
> should commit in MoveWork so we are using the same flow as normal tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
