[
https://issues.apache.org/jira/browse/HIVE-25208?focusedWorklogId=609545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609545
]
ASF GitHub Bot logged work on HIVE-25208:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 08:01
Start Date: 10/Jun/21 08:01
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2359:
URL: https://github.com/apache/hive/pull/2359#discussion_r648945402
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java
##########
@@ -317,6 +320,36 @@ public int execute() {
}
try (LocalTableLock lock =
acquireLockForFileMove(work.getLoadTableWork())) {
+ String storageHandlerClass = null;
Review comment:
Would it make sense to move this newly-added code into a method? e.g.
`boolean checkAndCommitNatively(work)` or something like that, with some
javadoc. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 609545)
Time Spent: 1h 40m (was: 1.5h)
> Refactor Iceberg commit to the MoveTask/MoveWork
> ------------------------------------------------
>
> Key: HIVE-25208
> URL: https://issues.apache.org/jira/browse/HIVE-25208
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Instead of committing Iceberg changes in `DefaultMetaHook.preCommitInsert` we
> should commit in MoveWork so we are using the same flow as normal tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
