[
https://issues.apache.org/jira/browse/HIVE-25423?focusedWorklogId=636059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636059
]
ASF GitHub Bot logged work on HIVE-25423:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/21 20:23
Start Date: 09/Aug/21 20:23
Worklog Time Spent: 10m
Work Description: dantongdong commented on a change in pull request #2559:
URL: https://github.com/apache/hive/pull/2559#discussion_r685495290
##########
File path: itests/qtest/pom.xml
##########
@@ -477,6 +477,23 @@
</profiles>
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <version>1.3.0</version>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <configuration>
+
<url>http://downloads.mariadb.com/Connectors/java/connector-java-2.2.0/mariadb-java-client-2.2.0.jar</url>
+ <outputFileName>mariadb-java-client-2.2.0.jar</outputFileName>
Review comment:
My main concern for using a place holder instead of hard-code is we have
the wget url, I am afraid that different version may have complication around
the wget url pattern? right now hive metastore init test is also using the
hard-coded version for that reason. So I think it may be better to leave it as
it is for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 636059)
Time Spent: 1.5h (was: 1h 20m)
> Add new test driver to automatically launch and load external database
> ----------------------------------------------------------------------
>
> Key: HIVE-25423
> URL: https://issues.apache.org/jira/browse/HIVE-25423
> Project: Hive
> Issue Type: Test
> Components: Testing Infrastructure, Tests
> Affects Versions: 3.1.2
> Reporter: Dantong Dong
> Assignee: Dantong Dong
> Priority: Major
> Labels: pull-request-available
> Attachments: Screen Shot 2021-08-04 at 2.32.35 PM.png
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add new test driver(TestMiniLlapExtDBCliDriver) to automatically launch and
> load external database with specified custom script during test. This Issue
> was originated from HIVE-24396. Will add docs later
> !Screen Shot 2021-08-04 at 2.32.35 PM.png|width=500,height=262!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
