[
https://issues.apache.org/jira/browse/HIVE-25423?focusedWorklogId=636150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636150
]
ASF GitHub Bot logged work on HIVE-25423:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/21 23:06
Start Date: 09/Aug/21 23:06
Worklog Time Spent: 10m
Work Description: dantongdong commented on a change in pull request #2559:
URL: https://github.com/apache/hive/pull/2559#discussion_r685577937
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/DerbyExternalDB.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.externalDB;
+
+/**
+ * MySQLExternalDB is a extension of abstractExternalDB
+ * Designed for MySQL external database connection
+ */
+public class DerbyExternalDB extends AbstractExternalDB {
+
+ public DerbyExternalDB() {
+ super("derby");
+ setJdbcUrl(getContainerHostAddress());
+ setJdbcDriver();
+ }
+
+ public void setJdbcUrl(String hostAddress) {
+ this.url = String.format("jdbc:derby:memory:%s;create=true", dbName);
+ }
+
+ public void setJdbcDriver() {
+ this.driver = "org.apache.derby.jdbc.EmbeddedDriver";
+ }
+
+ public String getDockerImageName() { return null; }
+
+ public String[] getDockerAdditionalArgs() { return null; }
+
+ public boolean isContainerReady(ProcessResults pr) { return true; }
Review comment:
Unlike mysql and postrges, Derby is an embedded database and does not
require container launch to work. So it will always return true to signal the
test driver to perceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 636150)
Time Spent: 2h (was: 1h 50m)
> Add new test driver to automatically launch and load external database
> ----------------------------------------------------------------------
>
> Key: HIVE-25423
> URL: https://issues.apache.org/jira/browse/HIVE-25423
> Project: Hive
> Issue Type: Test
> Components: Testing Infrastructure, Tests
> Affects Versions: 3.1.2
> Reporter: Dantong Dong
> Assignee: Dantong Dong
> Priority: Major
> Labels: pull-request-available
> Attachments: Screen Shot 2021-08-04 at 2.32.35 PM.png
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Add new test driver(TestMiniLlapExtDBCliDriver) to automatically launch and
> load external database with specified custom script during test. This Issue
> was originated from HIVE-24396. Will add docs later
> !Screen Shot 2021-08-04 at 2.32.35 PM.png|width=500,height=262!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
