[
https://issues.apache.org/jira/browse/HIVE-25883?focusedWorklogId=716350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716350
]
ASF GitHub Bot logged work on HIVE-25883:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/22 10:58
Start Date: 27/Jan/22 10:58
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2971:
URL: https://github.com/apache/hive/pull/2971#discussion_r793491772
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -448,15 +461,15 @@ private boolean isFileBelowWatermark(FileStatus child,
long highWatermark) {
Path p = child.getPath();
String fn = p.getName();
if (!child.isDirectory()) {
- return false;
+ return true;
}
if (fn.startsWith(AcidUtils.BASE_PREFIX)) {
ParsedBaseLight b = ParsedBaseLight.parseBase(p);
- return b.getWriteId() < highWatermark;
+ return b.getWriteId() <= highWatermark;
}
if (fn.startsWith(AcidUtils.DELTA_PREFIX) ||
fn.startsWith(AcidUtils.DELETE_DELTA_PREFIX)) {
ParsedDeltaLight d = ParsedDeltaLight.parse(p);
- return d.getMaxWriteId() < highWatermark;
+ return d.getMaxWriteId() <= highWatermark;
Review comment:
I think at some point
* the delta/base will become visible
* then the real acid dir will be using these files
* and the current one will become candidates for the cleaner
so I think the current logic makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 716350)
Time Spent: 2h 10m (was: 2h)
> Enhance Compaction Cleaner to skip when there is nothing to do
> --------------------------------------------------------------
>
> Key: HIVE-25883
> URL: https://issues.apache.org/jira/browse/HIVE-25883
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> the cleaner works the following way:
> * it identifies obsolete directories (delta dirs ; which doesn't have open
> txns)
> * removes them and done
> if there are no obsolete directoris that is attributed to that there might be
> open txns so the request should be retried later.
> however if for some reason the directory was already cleaned - similarily it
> has no obsolete directories; and thus the request is retried for forever
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
