[
https://issues.apache.org/jira/browse/HIVE-25883?focusedWorklogId=716985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716985
]
ASF GitHub Bot logged work on HIVE-25883:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/22 10:49
Start Date: 28/Jan/22 10:49
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2971:
URL: https://github.com/apache/hive/pull/2971#discussion_r794396068
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -448,15 +461,15 @@ private boolean isFileBelowWatermark(FileStatus child,
long highWatermark) {
Path p = child.getPath();
String fn = p.getName();
if (!child.isDirectory()) {
- return false;
+ return true;
}
if (fn.startsWith(AcidUtils.BASE_PREFIX)) {
ParsedBaseLight b = ParsedBaseLight.parseBase(p);
- return b.getWriteId() < highWatermark;
+ return b.getWriteId() <= highWatermark;
Review comment:
You're right. Might be worth adding test cases to make sure that the
Worker#isEnoughToCompact logic isn't changed though, because if it is then it
will break the cleaner.
e.g.
1. CQ_NEXT_TXN_ID is never updated (set it to NULL before the cleaner runs)
and table dir contains base_7
2. CQ_NEXT_TXN_ID is not updated (set it to NULL before the cleaner runs)
and table dir contains delta_1_7 and base_7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 716985)
Time Spent: 3h 40m (was: 3.5h)
> Enhance Compaction Cleaner to skip when there is nothing to do
> --------------------------------------------------------------
>
> Key: HIVE-25883
> URL: https://issues.apache.org/jira/browse/HIVE-25883
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> the cleaner works the following way:
> * it identifies obsolete directories (delta dirs ; which doesn't have open
> txns)
> * removes them and done
> if there are no obsolete directoris that is attributed to that there might be
> open txns so the request should be retried later.
> however if for some reason the directory was already cleaned - similarily it
> has no obsolete directories; and thus the request is retried for forever
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
