[
https://issues.apache.org/jira/browse/HIVE-25898?focusedWorklogId=718599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718599
]
ASF GitHub Bot logged work on HIVE-25898:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 11:47
Start Date: 01/Feb/22 11:47
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2981:
URL: https://github.com/apache/hive/pull/2981#discussion_r796516351
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -715,28 +705,29 @@ void wasSuccessful() {
* @throws Exception
*/
@Override public void close() throws Exception {
+ //the transaction is about to close, we can stop heartbeating regardless
of it's state
+ shutdownHeartbeater();
if (status != TxnStatus.UNKNOWN) {
- // turn off error logging in heartbeater in case of race condition
between commit/abort and heartbeating
- heartbeater.shouldLogError(false);
if (succeessfulCompaction) {
commit();
} else {
abort();
}
}
- shutdownHeartbeater();
}
private void shutdownHeartbeater() {
if (heartbeatExecutor != null) {
- heartbeatExecutor.shutdownNow();
try {
+ heartbeatExecutor.shutdownNow();
Review comment:
let's move it out of the try-catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 718599)
Time Spent: 50m (was: 40m)
> Compaction txn heartbeating after Worker timeout
> ------------------------------------------------
>
> Key: HIVE-25898
> URL: https://issues.apache.org/jira/browse/HIVE-25898
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In some cases, when the compaction transaction is aborted, the hearbeater
> thread is not shut down and keeps heartbeating.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
