[
https://issues.apache.org/jira/browse/HIVE-25898?focusedWorklogId=718609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718609
]
ASF GitHub Bot logged work on HIVE-25898:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 11:55
Start Date: 01/Feb/22 11:55
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2981:
URL: https://github.com/apache/hive/pull/2981#discussion_r796522231
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -339,15 +326,19 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
CompactionInfo ci = null;
boolean computeStats = false;
Table t1 = null;
- try (CompactionTxn compactionTxn = new CompactionTxn()) {
- if (msc == null) {
- try {
- msc = HiveMetaStoreUtils.getHiveMetastoreClient(conf);
- } catch (Exception e) {
- LOG.error("Failed to connect to HMS", e);
- return false;
- }
+
+ // If an exception is thrown in the try-with-resources block below, msc is
closed and nulled, so a new instance
+ // is need to be obtained here.
+ if (msc == null) {
+ try {
+ msc = HiveMetaStoreUtils.getHiveMetastoreClient(conf);
+ } catch (Exception e) {
+ LOG.error("Failed to connect to HMS", e);
+ return false;
Review comment:
shouldn't we throw an exception here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718609)
Time Spent: 1h 20m (was: 1h 10m)
> Compaction txn heartbeating after Worker timeout
> ------------------------------------------------
>
> Key: HIVE-25898
> URL: https://issues.apache.org/jira/browse/HIVE-25898
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In some cases, when the compaction transaction is aborted, the hearbeater
> thread is not shut down and keeps heartbeating.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
