[
https://issues.apache.org/jira/browse/HIVE-25918?focusedWorklogId=721913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721913
]
ASF GitHub Bot logged work on HIVE-25918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 13:43
Start Date: 07/Feb/22 13:43
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #2991:
URL: https://github.com/apache/hive/pull/2991#discussion_r800666998
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
##########
@@ -512,6 +513,8 @@ private String toString(Map<String, String> parameters) {
if (dpPartSpecs != null) {
// load the list of DP partitions and return the list of partition
specs
list.addAll(dpPartSpecs);
+ // Reload partition metadata because another BasicStatsTask instance
may have updated the stats.
+ list = db.getPartitionsByNames(table,
list.stream().map(Partition::getName).collect(Collectors.toList()));
Review comment:
Truth is that things are a bit different here (in comparison with the
state before HIVE-15250) in the sense that we are calling
`getPartitionsByNames` instead of `getPartition` so if I understand well it
will be only one call to DB and not multiple so maybe the perf overhead is not
as important as it was in HIVE-15250.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 721913)
Time Spent: 0.5h (was: 20m)
> Invalid stats after multi inserting into the same partition
> -----------------------------------------------------------
>
> Key: HIVE-25918
> URL: https://issues.apache.org/jira/browse/HIVE-25918
> Project: Hive
> Issue Type: Sub-task
> Components: Statistics
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code}
> create table source(p int, key int,value string);
> insert into source(p, key, value) values (101,42,'string42');
> create table stats_part(key int,value string) partitioned by (p int);
> from source
> insert into stats_part select key, value, p
> insert into stats_part select key, value, p;
> select count(*) from stats_part;
> {code}
> In this case {{StatsOptimizer}} helps serving this query because the result
> should be {{rowNum}} of the partition {{p=101}}. The result is
> {code}
> 1
> {code}
> however it shloud be
> {code}
> 2
> {code}
> because both insert branches inserts 1-1 records.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
