[
https://issues.apache.org/jira/browse/HIVE-25918?focusedWorklogId=722413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722413
]
ASF GitHub Bot logged work on HIVE-25918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 23:11
Start Date: 07/Feb/22 23:11
Worklog Time Spent: 10m
Work Description: rbalamohan commented on a change in pull request #2991:
URL: https://github.com/apache/hive/pull/2991#discussion_r801136555
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
##########
@@ -512,6 +513,8 @@ private String toString(Map<String, String> parameters) {
if (dpPartSpecs != null) {
// load the list of DP partitions and return the list of partition
specs
list.addAll(dpPartSpecs);
+ // Reload partition metadata because another BasicStatsTask instance
may have updated the stats.
+ list = db.getPartitionsByNames(table,
list.stream().map(Partition::getName).collect(Collectors.toList()));
Review comment:
getPartitionByNames is a single call unlike 2000+ getPartition() calls
(Which internally loads table object everytime etc). It will still add up to
runtime depending on the number of partitions for regular insert queries.
One option could be to figure out if it is multi-insert at the time of sem
analyzer and pass it on to DynamicPartitionCtx; getPartitionByNames() could be
invoked only in those conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 722413)
Time Spent: 50m (was: 40m)
> Invalid stats after multi inserting into the same partition
> -----------------------------------------------------------
>
> Key: HIVE-25918
> URL: https://issues.apache.org/jira/browse/HIVE-25918
> Project: Hive
> Issue Type: Sub-task
> Components: Statistics
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> create table source(p int, key int,value string);
> insert into source(p, key, value) values (101,42,'string42');
> create table stats_part(key int,value string) partitioned by (p int);
> from source
> insert into stats_part select key, value, p
> insert into stats_part select key, value, p;
> select count(*) from stats_part;
> {code}
> In this case {{StatsOptimizer}} helps serving this query because the result
> should be {{rowNum}} of the partition {{p=101}}. The result is
> {code}
> 1
> {code}
> however it shloud be
> {code}
> 2
> {code}
> because both insert branches inserts 1-1 records.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
