[
https://issues.apache.org/jira/browse/HIVE-25953?focusedWorklogId=731684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731684
]
ASF GitHub Bot logged work on HIVE-25953:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 16:29
Start Date: 23/Feb/22 16:29
Worklog Time Spent: 10m
Work Description: asolimando commented on a change in pull request #3033:
URL: https://github.com/apache/hive/pull/3033#discussion_r813079737
##########
File path: ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
##########
@@ -491,25 +484,25 @@ STAGE PLANS:
aggregations: count(VALUE._col0)
mode: mergepartial
outputColumnNames: _col0
- Statistics: Num rows: 1 Data size: 196 Basic stats: COMPLETE
Column stats: NONE
- Limit
- Number of rows: 0
- Statistics: Num rows: 0 Data size: 0 Basic stats: COMPLETE
Column stats: NONE
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
+ Filter Operator
+ predicate: sq_count_check(_col0) (type: boolean)
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
Review comment:
In Calcite, `false` predicates produce a rewrite of the whole subtree as
`LogicalValues(tuples=[[]])`, that's why this case is not handled there. The
addition of those two lines to Calcite would be trivial, but since this case
can't happen, it cannot be reproduced in Calcite and it's hard to justify the
change.
I don't know if this can be considered a blocker, it seems a rather extreme
case to me.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 731684)
Time Spent: 1h (was: 50m)
> Drop HiveRelMdPredicates::getPredicates(Join...) to use that of
> RelMdPredicates
> -------------------------------------------------------------------------------
>
> Key: HIVE-25953
> URL: https://issues.apache.org/jira/browse/HIVE-25953
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The goal of the ticket is to unify the two implementations and remove the
> override in HiveRelMdPredicates.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
