[
https://issues.apache.org/jira/browse/HIVE-25953?focusedWorklogId=732313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732313
]
ASF GitHub Bot logged work on HIVE-25953:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 13:55
Start Date: 24/Feb/22 13:55
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3033:
URL: https://github.com/apache/hive/pull/3033#discussion_r813901841
##########
File path: ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
##########
@@ -491,25 +484,25 @@ STAGE PLANS:
aggregations: count(VALUE._col0)
mode: mergepartial
outputColumnNames: _col0
- Statistics: Num rows: 1 Data size: 196 Basic stats: COMPLETE
Column stats: NONE
- Limit
- Number of rows: 0
- Statistics: Num rows: 0 Data size: 0 Basic stats: COMPLETE
Column stats: NONE
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
+ Filter Operator
+ predicate: sq_count_check(_col0) (type: boolean)
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
Review comment:
I am not very familiar with the code but I assume that "non field
predicates" does not necessarily mean only `false`. Isn't it possible to craft
a predicate other than `false`; what about `RAND() < 0.5` for instance?
Unfortunately, I think it is a blocker cause if I understand well it causes
performance regressions and the latter can be significant ones. In addition,
the fact that this change is mostly a refactoring and not something fixing a
bug or adding a feature, means that we don't need to rush it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 732313)
Time Spent: 1.5h (was: 1h 20m)
> Drop HiveRelMdPredicates::getPredicates(Join...) to use that of
> RelMdPredicates
> -------------------------------------------------------------------------------
>
> Key: HIVE-25953
> URL: https://issues.apache.org/jira/browse/HIVE-25953
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of the ticket is to unify the two implementations and remove the
> override in HiveRelMdPredicates.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
