[ 
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=753929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753929
 ]

ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Apr/22 09:37
            Start Date: 07/Apr/22 09:37
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r844929235


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##########
@@ -224,7 +232,7 @@ public Writable serialize(Object o, ObjectInspector 
objectInspector) {
     Deserializer deserializer = deserializers.get(objectInspector);
     if (deserializer == null) {
       deserializer = new Deserializer.Builder()
-          .schema(tableSchema)
+          .schema(isDelete ? deleteSchema : tableSchema)

Review Comment:
   Why not use the `projectedSchema` here?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 753929)
    Time Spent: 8.5h  (was: 8h 20m)

> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
>                 Key: HIVE-26102
>                 URL: https://issues.apache.org/jira/browse/HIVE-26102
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 8.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to