[ 
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=753967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753967
 ]

ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Apr/22 10:53
            Start Date: 07/Apr/22 10:53
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r844995858


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -234,22 +240,23 @@ private static void checkResiduals(CombinedScanTask task) 
{
     private CloseableIterator<T> currentIterator;
     private FileIO io;
     private EncryptionManager encryptionManager;
+    private Table table;

Review Comment:
   We need the whole table object for this call:
   ```
   public static NestedField metadataColumn(Table table, String name)
   ```
   (which is called inside IcebergAcidUtil#createFileReadSchemaForDelete)
   -> this gives us the _partition metadata column during file read





Issue Time Tracking
-------------------

    Worklog Id:     (was: 753967)
    Time Spent: 10h 10m  (was: 10h)

> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
>                 Key: HIVE-26102
>                 URL: https://issues.apache.org/jira/browse/HIVE-26102
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to