[
https://issues.apache.org/jira/browse/HIVE-26133?focusedWorklogId=755745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755745
]
ASF GitHub Bot logged work on HIVE-26133:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 13:27
Start Date: 12/Apr/22 13:27
Worklog Time Spent: 10m
Work Description: lcspinter opened a new pull request, #3202:
URL: https://github.com/apache/hive/pull/3202
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
When running an IOW operation we should check whether partition evolution
happened or not. If it is the case, we should validate that the specId of the
data manifest files are the same as the current specId. If all the specIds
match the current one, it means that the data was rewritten and we are safe to
complete the IOW operation. Otherwise, we should throw an exception.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Avoid data duplication when running IOW on Iceberg tables with partition
evolution
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Manual test, unit test
Issue Time Tracking
-------------------
Worklog Id: (was: 755745)
Remaining Estimate: 0h
Time Spent: 10m
> Insert overwrite on Iceberg tables can result in duplicate entries after
> partition evolution
> --------------------------------------------------------------------------------------------
>
> Key: HIVE-26133
> URL: https://issues.apache.org/jira/browse/HIVE-26133
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Insert overwrite commands in Hive only rewrite partitions affected by the
> query.
> If we write out a record with specA (e.g. day(ts)), resulting in a datafile:
> "/tableRoot/data/ts_day="2020-10-24"/ffffgggg.orc
> If you then change to specB (e.g. day(ts), name), the same record would go to
> a different partition:
> "/tableRoot/data/ts_day="2020-10-24"/name="Mike"/ffffgggg.orc
> If you then want to overwrite the table with itself, it will detect these two
> records to belong to different partitions (as they do), and therefore does
> not overwrite the original record with the new one, resulting in duplicate
> entries.
> {code:java}
> create table testice1000 (a int, b string) stored by iceberg stored as orc
> location 'file:/tmp/testice1000';
> insert into testice1000 values (11, 'ddd'), (22, 'ttt');
> alter table testice1000 set partition spec(truncate(2, b));
> insert into testice1000 values (33, 'rrfdfdf');
> insert overwrite table testice1000 select * from testice1000;
> ------------------------------+
> testice1000.a testice1000.b
> ------------------------------+
> 11 ddd
> 11 ddd
> 22 ttt
> 22 ttt
> 33 rrfdfdf
> ------------------------------+
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
