[
https://issues.apache.org/jira/browse/HIVE-26133?focusedWorklogId=755753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755753
]
ASF GitHub Bot logged work on HIVE-26133:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 13:39
Start Date: 12/Apr/22 13:39
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3202:
URL: https://github.com/apache/hive/pull/3202#discussion_r848449913
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergInserts.java:
##########
@@ -183,6 +183,22 @@ public void
testInsertOverwriteBucketPartitionedTableThrowsError() {
testTables.getInsertQuery(HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS,
target, true)));
}
+ @Test
+ public void testInsertOverwriteWithPartitionEvolutionThrowsError() throws
IOException {
Review Comment:
It would be great to have a test where we:
- create table and insert data
- evolve partition spec
- insert more data
- try IOW -> fails
- rewrite old data files
- try IOW -> succeeds
Right now we don't have the tools for this, because rewriting the old data
will be best achieved using the MERGE statement - so in the meantime, can we
insert a TODO line to add some testing for this once MERGE is available?
Issue Time Tracking
-------------------
Worklog Id: (was: 755753)
Time Spent: 40m (was: 0.5h)
> Insert overwrite on Iceberg tables can result in duplicate entries after
> partition evolution
> --------------------------------------------------------------------------------------------
>
> Key: HIVE-26133
> URL: https://issues.apache.org/jira/browse/HIVE-26133
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Insert overwrite commands in Hive only rewrite partitions affected by the
> query.
> If we write out a record with specA (e.g. day(ts)), resulting in a datafile:
> "/tableRoot/data/ts_day="2020-10-24"/ffffgggg.orc
> If you then change to specB (e.g. day(ts), name), the same record would go to
> a different partition:
> "/tableRoot/data/ts_day="2020-10-24"/name="Mike"/ffffgggg.orc
> If you then want to overwrite the table with itself, it will detect these two
> records to belong to different partitions (as they do), and therefore does
> not overwrite the original record with the new one, resulting in duplicate
> entries.
> {code:java}
> create table testice1000 (a int, b string) stored by iceberg stored as orc
> location 'file:/tmp/testice1000';
> insert into testice1000 values (11, 'ddd'), (22, 'ttt');
> alter table testice1000 set partition spec(truncate(2, b));
> insert into testice1000 values (33, 'rrfdfdf');
> insert overwrite table testice1000 select * from testice1000;
> ------------------------------+
> testice1000.a testice1000.b
> ------------------------------+
> 11 ddd
> 11 ddd
> 22 ttt
> 22 ttt
> 33 rrfdfdf
> ------------------------------+
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
