[ 
https://issues.apache.org/jira/browse/HIVE-26233?focusedWorklogId=773249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773249
 ]

ASF GitHub Bot logged work on HIVE-26233:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/May/22 20:48
            Start Date: 22/May/22 20:48
    Worklog Time Spent: 10m 
      Work Description: zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r878923538


##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java:
##########
@@ -389,6 +390,26 @@ public void testIllegalInt64TimestampStrings() {
     verifyInt64TimestampValue("2262-04-11 23:47:16.854775808", 
LogicalTypeAnnotation.TimeUnit.NANOS, false);
   }
 
+  @Test

Review Comment:
   The test passes successfully if you exclude all the changes in this PR and 
revert some lines in `NanoTimeUtils` as I mentioned in the JIRA case. This 
makes me think that we need to treat the problem differently since it does not 
appear to be related to the formatter.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 773249)
    Time Spent: 20m  (was: 10m)

> Problems reading back PARQUET timestamps above 10000 years
> ----------------------------------------------------------
>
>                 Key: HIVE-26233
>                 URL: https://issues.apache.org/jira/browse/HIVE-26233
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: backwards-compatibility, pull-request-available, 
> timestamp
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Timestamp values above year 10000 are not supported, but during the migration 
> from Hive2 to Hive3 some might appear because of TZ issues. We should be able 
> to at least read these tables before rewriting the data.
> For this we need to change the Timestamp.PRINT_FORMATTER, so no {{+}} sign is 
> appended to the timestamp if the year exceeds 4 digits.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to