[
https://issues.apache.org/jira/browse/HIVE-26233?focusedWorklogId=774576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774576
]
ASF GitHub Bot logged work on HIVE-26233:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 14:09
Start Date: 25/May/22 14:09
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r881702228
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java:
##########
@@ -389,6 +390,26 @@ public void testIllegalInt64TimestampStrings() {
verifyInt64TimestampValue("2262-04-11 23:47:16.854775808",
LogicalTypeAnnotation.TimeUnit.NANOS, false);
}
+ @Test
+ public void testTimestamp9999() {
Review Comment:
Or rather enrich the tests inside `TestParquetTimestampsHive2Compatibility`
to account for this edge case.
Issue Time Tracking
-------------------
Worklog Id: (was: 774576)
Time Spent: 1.5h (was: 1h 20m)
> Problems reading back PARQUET timestamps above 10000 years
> ----------------------------------------------------------
>
> Key: HIVE-26233
> URL: https://issues.apache.org/jira/browse/HIVE-26233
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: backwards-compatibility, pull-request-available,
> timestamp
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Timestamp values above year 10000 are not supported, but during the migration
> from Hive2 to Hive3 some might appear because of TZ issues. We should be able
> to at least read these tables before rewriting the data.
> For this we need to change the Timestamp.PRINT_FORMATTER, so no {{+}} sign is
> appended to the timestamp if the year exceeds 4 digits.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
