[ https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783130 ]
ASF GitHub Bot logged work on HIVE-21456: ----------------------------------------- Author: ASF GitHub Bot Created on: 20/Jun/22 21:48 Start Date: 20/Jun/22 21:48 Worklog Time Spent: 10m Work Description: hsnusonic commented on code in PR #3381: URL: https://github.com/apache/hive/pull/3381#discussion_r901977331 ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: ########## @@ -461,6 +459,14 @@ public Thread newThread(@NotNull Runnable r) { // TODO: AcceptQueueSize needs to be higher for HMS connector.setAcceptQueueSize(maxWorkerThreads); // TODO: Connection keepalive configuration? + connector.addBean(new HttpChannel.Listener() { + @Override + public void onComplete(Request request) { + LOG.debug("Request " + request + " is completed. HttpChannel was: " + request.getHttpChannel() + + ", HttpTransport: " + request.getHttpChannel().getHttpTransport()); + HMSHandler.cleanupHandlerContext(); Review Comment: Is it possible to add a unit test to make sure we indeed clean up all of objects that need to be removed? Issue Time Tracking ------------------- Worklog Id: (was: 783130) Time Spent: 7h 20m (was: 7h 10m) > Hive Metastore Thrift over HTTP > ------------------------------- > > Key: HIVE-21456 > URL: https://issues.apache.org/jira/browse/HIVE-21456 > Project: Hive > Issue Type: New Feature > Components: Metastore, Standalone Metastore > Reporter: Amit Khanna > Assignee: Sourabh Goyal > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, > HIVE-21456.4.patch, HIVE-21456.patch > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Hive Metastore currently doesn't have support for HTTP transport because of > which it is not possible to access it via Knox. Adding support for Thrift > over HTTP transport will allow the clients to access via Knox -- This message was sent by Atlassian Jira (v8.20.7#820007)