[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783131
]
ASF GitHub Bot logged work on HIVE-21456:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/22 21:49
Start Date: 20/Jun/22 21:49
Worklog Time Spent: 10m
Work Description: hsnusonic commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r901986870
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -399,19 +403,13 @@ private static ThriftServer startHttpMetastore(int port,
Configuration conf)
// Start with minWorkerThreads, expand till maxWorkerThreads and reject
// subsequent requests
final String threadPoolNamePrefix = "HiveMetastore-HttpHandler-Pool";
- ExecutorService executorService = new ThreadPoolExecutor(
- minWorkerThreads, maxWorkerThreads, 60, TimeUnit.SECONDS,
- new SynchronousQueue<>(), new ThreadFactory() {
- @Override
- public Thread newThread(@NotNull Runnable r) {
- Thread newThread = new Thread(r);
- newThread.setName(threadPoolNamePrefix + ": Thread-" +
newThread.getId());
- return newThread;
- }
- });
- ExecutorThreadPool threadPool = new
ExecutorThreadPool((ThreadPoolExecutor) executorService);
+ ExecutorThreadPool executorThreadPool = new
ExecutorThreadPool(maxWorkerThreads, minWorkerThreads,
Review Comment:
Could you give me some context why the change is needed? It seems netty has
default idle timeout 30 seconds, but it was declared 60 seconds explicitly.
Issue Time Tracking
-------------------
Worklog Id: (was: 783131)
Time Spent: 7.5h (was: 7h 20m)
> Hive Metastore Thrift over HTTP
> -------------------------------
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
> Reporter: Amit Khanna
> Assignee: Sourabh Goyal
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch,
> HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of
> which it is not possible to access it via Knox. Adding support for Thrift
> over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
