[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798715
]
ASF GitHub Bot logged work on HIVE-24933:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/22 12:34
Start Date: 07/Aug/22 12:34
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938518815
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
+ void setupWork(ReplCopyWork replCopyWork) throws HiveException;
+ void setupWork(MoveWork moveWork) throws HiveException;
Review Comment:
Currently, the copyWork, ReplCopyWork and MoveWork do not share a common
base class/interface. CopyWork is a base class for ReplCopyWork. MoveWork is
not related to these classes. Do you suggest that we define a new base
class/interface and then extend these classes? That base class will only have a
single function that will need to be implemented.
Issue Time Tracking
-------------------
Worklog Id: (was: 798715)
Time Spent: 3.5h (was: 3h 20m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
> Reporter: Pratyush Madhukar
> Assignee: Pratyush Madhukar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)