[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=801856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801856
]
ASF GitHub Bot logged work on HIVE-24933:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/22 04:08
Start Date: 19/Aug/22 04:08
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r949782006
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java:
##########
@@ -26,15 +26,23 @@
import org.apache.hadoop.hive.ql.exec.Utilities;
import org.apache.hadoop.hive.ql.hooks.ReadEntity;
import org.apache.hadoop.hive.ql.hooks.WriteEntity;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.parse.ImportSemanticAnalyzer;
import org.apache.hadoop.hive.ql.parse.repl.metric.ReplicationMetricCollector;
+import org.apache.hadoop.hive.ql.plan.BaseCopyWork;
+import org.apache.hadoop.hive.ql.plan.DeferredWorkHelper;
import org.apache.hadoop.hive.ql.plan.Explain.Level;
+import java.util.Collections;
+import java.util.TreeMap;
+
/**
* MoveWork.
*
*/
@Explain(displayName = "Move Operator", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
-public class MoveWork implements Serializable {
+public class MoveWork implements Serializable, BaseCopyWork {
Review Comment:
> Doesn't CopyWork and ReplCopyWork also need to implement BaseCopyWork? I
don't see it.
Ah, Thanks for pointing out. I missed it in CopyWork. I will extend CopyWork
to implement BaseCopyWork. ReplCopyWork inherits CopyWork. Hence, I think, we
only need to override the setupWork in ReplCopyWork.
I will push a new patchset shortly.
Thanks,
Janardhan
Issue Time Tracking
-------------------
Worklog Id: (was: 801856)
Time Spent: 4h (was: 3h 50m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
> Reporter: Pratyush Madhukar
> Assignee: Pratyush Madhukar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
