[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=802034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802034
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/22 15:00
Start Date: 19/Aug/22 15:00
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r950288043
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -90,8 +94,23 @@ private String getPartitionName(Table table) throws
HiveException {
}
private CompactionResponse compact(Table table, String partitionName) throws
HiveException {
- CompactionResponse resp = context.getDb().compact2(table.getDbName(),
table.getTableName(), partitionName,
- desc.getCompactionType(), desc.getProperties());
+ CompactionType compactionType = null;
+ String strType = desc.getCompactionType();
+ if ("major".equalsIgnoreCase(strType)) {
+ compactionType = CompactionType.MAJOR;
Review Comment:
Can't we use valueOf() for string to enum conversion ?
Issue Time Tracking
-------------------
Worklog Id: (was: 802034)
Time Spent: 2h 10m (was: 2h)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
