[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=802036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802036
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/22 15:03
Start Date: 19/Aug/22 15:03
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r950290958
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java:
##########
@@ -95,10 +95,11 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
}
}
- private void compactAcidTable(TableName tableName, Map<String, String>
partitionSpec) throws SemanticException {
+ private void compactAcidTable(Table table, TableName tableName, Map<String,
String> partitionSpec) throws SemanticException {
boolean isBlocking = !HiveConf.getBoolVar(conf,
ConfVars.TRANSACTIONAL_CONCATENATE_NOBLOCK, false);
- AlterTableCompactDesc desc = new AlterTableCompactDesc(tableName,
partitionSpec, "MAJOR", isBlocking, null);
+ AlterTableCompactDesc desc = new AlterTableCompactDesc(tableName,
partitionSpec, "MAJOR", isBlocking,
Review Comment:
can we use CompactionType enum name instead of hardcoded string (magic
number)
Issue Time Tracking
-------------------
Worklog Id: (was: 802036)
Time Spent: 2.5h (was: 2h 20m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
