[
https://issues.apache.org/jira/browse/HIVE-26474?focusedWorklogId=803630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803630
]
ASF GitHub Bot logged work on HIVE-26474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 13:23
Start Date: 25/Aug/22 13:23
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r954963344
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java:
##########
@@ -178,6 +178,12 @@ public static boolean isAcidTable(Map<String, String>
parameters) {
equals(parameters.get(hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES));
}
+ public static boolean isInsertOnlyTable(Table table) {
+ return TxnUtils.isTransactionalTable(table) &&
+
TransactionalValidationListener.INSERTONLY_TRANSACTIONAL_PROPERTY.equals(table.getParameters()
Review Comment:
maybe static import to shorten the line for readability
Issue Time Tracking
-------------------
Worklog Id: (was: 803630)
Time Spent: 0.5h (was: 20m)
> Enable converting insert-only tables to full ACID tables
> --------------------------------------------------------
>
> Key: HIVE-26474
> URL: https://issues.apache.org/jira/browse/HIVE-26474
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently we can convert a non-ACID table to full ACID via altering
> TBLPROPERTIES ("transactional"="false" -> "transactional"="true"), but we
> don't support converting insert-only tables to full ACID tables
> ("transactional_properties"="insert_only" - >
> "transactional_properties"="default").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
