[
https://issues.apache.org/jira/browse/HIVE-26474?focusedWorklogId=803635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803635
]
ASF GitHub Bot logged work on HIVE-26474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 13:29
Start Date: 25/Aug/22 13:29
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r954967929
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:
##########
@@ -217,10 +217,10 @@ private void
handleAlterTableTransactionalProp(PreAlterTableEvent context) throw
}
}
checkSorted(newTable);
- if(TxnUtils.isAcidTable(newTable) && !TxnUtils.isAcidTable(oldTable)) {
+ if(TxnUtils.isAcidTable(newTable) && !TxnUtils.isAcidTable(oldTable) &&
!TxnUtils.isInsertOnlyTable(oldTable) ) {
Review Comment:
can't we simply check !TxnUtils.isTransactionalTable(oldTable) instead of
!TxnUtils.isAcidTable(oldTable) && !TxnUtils.isInsertOnlyTable(oldTable)
Issue Time Tracking
-------------------
Worklog Id: (was: 803635)
Time Spent: 1h (was: 50m)
> Enable converting insert-only tables to full ACID tables
> --------------------------------------------------------
>
> Key: HIVE-26474
> URL: https://issues.apache.org/jira/browse/HIVE-26474
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently we can convert a non-ACID table to full ACID via altering
> TBLPROPERTIES ("transactional"="false" -> "transactional"="true"), but we
> don't support converting insert-only tables to full ACID tables
> ("transactional_properties"="insert_only" - >
> "transactional_properties"="default").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
