[
https://issues.apache.org/jira/browse/HIVE-26474?focusedWorklogId=804659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804659
]
ASF GitHub Bot logged work on HIVE-26474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/22 07:21
Start Date: 30/Aug/22 07:21
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r958097172
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java:
##########
@@ -168,16 +169,22 @@ public static boolean isTransactionalTable(Map<String,
String> parameters) {
*/
public static boolean isAcidTable(Table table) {
return TxnUtils.isTransactionalTable(table) &&
-
TransactionalValidationListener.DEFAULT_TRANSACTIONAL_PROPERTY.equals(table.getParameters()
+ DEFAULT_TRANSACTIONAL_PROPERTY.equals(table.getParameters()
Review Comment:
can't we simply call `isAcidTable(table.getParameters())` ? It's a
duplicated code. Same in isTransactionalTable.
Issue Time Tracking
-------------------
Worklog Id: (was: 804659)
Time Spent: 3h 20m (was: 3h 10m)
> Enable converting insert-only tables to full ACID tables
> --------------------------------------------------------
>
> Key: HIVE-26474
> URL: https://issues.apache.org/jira/browse/HIVE-26474
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently we can convert a non-ACID table to full ACID via altering
> TBLPROPERTIES ("transactional"="false" -> "transactional"="true"), but we
> don't support converting insert-only tables to full ACID tables
> ("transactional_properties"="insert_only" - >
> "transactional_properties"="default").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
