[
https://issues.apache.org/jira/browse/HIVE-26474?focusedWorklogId=804685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804685
]
ASF GitHub Bot logged work on HIVE-26474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/22 07:40
Start Date: 30/Aug/22 07:40
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r958115380
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -2265,6 +2268,55 @@ public static Boolean isToInsertOnlyTable(Table tbl,
Map<String, String> props)
return true;
}
+ public static Boolean isToFullAcid(Table table, Map<String, String> props) {
+ String transactional =
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
Review Comment:
can we simplify this a bit?
````
if (table == null || !TxnUtils.isTransactionalTable(props)) {
return false;
}
````
I don't understand how it's possible that transactionalProp!= null, but
transactional = null.
Issue Time Tracking
-------------------
Worklog Id: (was: 804685)
Time Spent: 3h 40m (was: 3.5h)
> Enable converting insert-only tables to full ACID tables
> --------------------------------------------------------
>
> Key: HIVE-26474
> URL: https://issues.apache.org/jira/browse/HIVE-26474
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently we can convert a non-ACID table to full ACID via altering
> TBLPROPERTIES ("transactional"="false" -> "transactional"="true"), but we
> don't support converting insert-only tables to full ACID tables
> ("transactional_properties"="insert_only" - >
> "transactional_properties"="default").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
