[
https://issues.apache.org/jira/browse/HIVE-26584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612481#comment-17612481
]
Ayush Saxena commented on HIVE-26584:
-------------------------------------
Changing tables from External to Managed, seems to be changing a bit core of
the test. We shouldn't change the functional bit of the test to fix the
flakiness, though the table type might not look relevant in the current test
case or may be yes.
* We can have {{hive.external.table.purge.default}} set to true, if we want to
get the data deleted for the external tables?
* Second, In the tests, Can we not first delete the directory & then use it
giving it scope, if there is some leftovers? This should be a one liner and
should get us sorted? In couple of test there is something Like DROP TABLE IF
EXIST before creates, may be same stuff for the filesystem directories, before
using, clean it up? giving it scope if some failed test didn't do that or
failed to do that
* Is there a scope like post every .q test we do a recursive delete inside
{{{}system:test.tmp.dir{}}}? That should also solve the problem for all the
tests affected by this issue?
In general we should try to have minimal changes to the core of the existing
test as far as possible to get rid of the flakiness.
> compressed_skip_header_footer_aggr.q is flaky
> ---------------------------------------------
>
> Key: HIVE-26584
> URL: https://issues.apache.org/jira/browse/HIVE-26584
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Affects Versions: 4.0.0-alpha-2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of my PRs compressed_skip_header_footer_aggr.q was failing with
> unexpected diff. Such as:
> {code:java}
> TestMiniLlapLocalCliDriver.testCliDriver:62 Client Execution succeeded but
> contained differences (error code = 1) after executing
> compressed_skip_header_footer_aggr.q
> 69,71c69,70
> < 1 2019-12-31
> < 2 2018-12-31
> < 3 2017-12-31
> ---
> > 2 2019-12-31
> > 3 2019-12-31
> 89d87
> < NULL NULL
> 91c89
> < 2 2018-12-31
> ---
> > 2 2019-12-31
> 100c98
> < 1
> ---
> > 2
> 109c107
> < 1 2019-12-31
> ---
> > 2 2019-12-31
> 127,128c125,126
> < 1 2019-12-31
> < 3 2017-12-31
> ---
> > 2 2019-12-31
> > 3 2019-12-31
> 146a145
> > 2 2019-12-31
> 155c154
> < 1
> ---
> > 2 {code}
> Investigating it, it did not seem to fail when executed locally. Since I
> suspected test interference I searched for the tablenames/directories used
> and discovered empty_skip_header_footer_aggr.q which uses the same table
> names AND external directories.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
