[
https://issues.apache.org/jira/browse/HIVE-26584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612615#comment-17612615
]
Stamatis Zampetakis commented on HIVE-26584:
--------------------------------------------
Many thanks for the detailed analysis [~jfs] and [~ayushtkn] for keeping an eye
on this!
Before checking the changes in the PR in detail I would like to point out the
[QTestUtil#clearTablesCreatedDuringTests|
https://github.com/apache/hive/blob/95d088a752f1c04f33c9c56556f0f939a1c9ea42/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java#L342]
method. The method tries to clear any kind of side effects coming from table
creation and there is code trying to address [directories coming from external
tables|https://github.com/apache/hive/blob/95d088a752f1c04f33c9c56556f0f939a1c9ea42/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java#L395].
I am wondering if this is an appropriate place to address the flakiness
observed here.
> compressed_skip_header_footer_aggr.q is flaky
> ---------------------------------------------
>
> Key: HIVE-26584
> URL: https://issues.apache.org/jira/browse/HIVE-26584
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Affects Versions: 4.0.0-alpha-2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of my PRs compressed_skip_header_footer_aggr.q was failing with
> unexpected diff. Such as:
> {code:java}
> TestMiniLlapLocalCliDriver.testCliDriver:62 Client Execution succeeded but
> contained differences (error code = 1) after executing
> compressed_skip_header_footer_aggr.q
> 69,71c69,70
> < 1 2019-12-31
> < 2 2018-12-31
> < 3 2017-12-31
> ---
> > 2 2019-12-31
> > 3 2019-12-31
> 89d87
> < NULL NULL
> 91c89
> < 2 2018-12-31
> ---
> > 2 2019-12-31
> 100c98
> < 1
> ---
> > 2
> 109c107
> < 1 2019-12-31
> ---
> > 2 2019-12-31
> 127,128c125,126
> < 1 2019-12-31
> < 3 2017-12-31
> ---
> > 2 2019-12-31
> > 3 2019-12-31
> 146a145
> > 2 2019-12-31
> 155c154
> < 1
> ---
> > 2 {code}
> Investigating it, it did not seem to fail when executed locally. Since I
> suspected test interference I searched for the tablenames/directories used
> and discovered empty_skip_header_footer_aggr.q which uses the same table
> names AND external directories.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
