[ https://issues.apache.org/jira/browse/HIVE-26680?focusedWorklogId=824715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824715 ]
ASF GitHub Bot logged work on HIVE-26680: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Nov/22 17:58 Start Date: 09/Nov/22 17:58 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3715: URL: https://github.com/apache/hive/pull/3715#discussion_r1018254056 ########## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ########## @@ -7990,19 +7998,29 @@ protected boolean enableColumnStatsCollecting() { return true; } - private Path getCtasLocation(CreateTableDesc tblDesc, boolean createTableWithSuffix) throws SemanticException { + private Path getCtasOrCMVLocation(CreateTableDesc tblDesc, CreateMaterializedViewDesc viewDesc, + boolean createTableWithSuffix) throws SemanticException { Path location; + String protoName; + String[] names; + Table tbl; try { - String protoName = tblDesc.getDbTableName(); - String[] names = Utilities.getDbTableName(protoName); - - // Handle table translation initially and if not present - // use default table path. - // Property modifications of the table is handled later. - // We are interested in the location if it has changed - // due to table translation. - Table tbl = tblDesc.toTable(conf); - tbl = db.getTranslateTableDryrun(tbl.getTTable()); + if (tblDesc != null) { + protoName = tblDesc.getDbTableName(); + names = Utilities.getDbTableName(protoName); + + // Handle table translation initially and if not present + // use default table path. + // Property modifications of the table is handled later. + // We are interested in the location if it has changed + // due to table translation. + tbl = tblDesc.toTable(conf); + tbl = db.getTranslateTableDryrun(tbl.getTTable()); Review Comment: shouldn't we do the translation for MV as well? Issue Time Tracking ------------------- Worklog Id: (was: 824715) Time Spent: 2h 50m (was: 2h 40m) > Make CMV use Direct Insert Semantics > ------------------------------------ > > Key: HIVE-26680 > URL: https://issues.apache.org/jira/browse/HIVE-26680 > Project: Hive > Issue Type: Improvement > Reporter: Sourabh Badhya > Assignee: Sourabh Badhya > Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > As similar to CTAS, CMV can also use Direct Insert approach which can > potentially save a lot of filesystem operations. -- This message was sent by Atlassian Jira (v8.20.10#820010)