[
https://issues.apache.org/jira/browse/HIVE-26680?focusedWorklogId=824716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824716
]
ASF GitHub Bot logged work on HIVE-26680:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/22 18:01
Start Date: 09/Nov/22 18:01
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3715:
URL: https://github.com/apache/hive/pull/3715#discussion_r1018257262
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7917,17 +7929,13 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
destinationPath, currentTableId, destTableIsFullAcid,
destTableIsTemporary,//this was 1/4 acid
destTableIsMaterialization, queryTmpdir, rsCtx, dpCtx, lbCtx, fsRS,
canBeMerged, destinationTable, writeId, isMmCreate, destType, qb,
isDirectInsert, acidOperation, moveTaskId);
- if (isMmCreate) {
+ if (isMmCreate || ((qb.isCTAS() || qb.isMaterializedView()) &&
isDirectInsert)) {
Review Comment:
unneeded extra brackets:
````
(isMmCreate || (qb.isCTAS() || qb.isMaterializedView()) && isDirectInsert)
````
Issue Time Tracking
-------------------
Worklog Id: (was: 824716)
Time Spent: 3h (was: 2h 50m)
> Make CMV use Direct Insert Semantics
> ------------------------------------
>
> Key: HIVE-26680
> URL: https://issues.apache.org/jira/browse/HIVE-26680
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> As similar to CTAS, CMV can also use Direct Insert approach which can
> potentially save a lot of filesystem operations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
