[
https://issues.apache.org/jira/browse/HIVE-26537?focusedWorklogId=854182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854182
]
ASF GitHub Bot logged work on HIVE-26537:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 12:49
Start Date: 31/Mar/23 12:49
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1154436457
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2070,18 +2096,30 @@ struct CreateDatabaseRequest {
8: optional string catalogName,
9: optional i32 createTime,
10: optional string managedLocationUri,
- 11: optional string type,
- 12: optional string dataConnectorName
+ 11: optional DatabaseType type,
+ 12: optional string dataConnectorName,
+ 13: optional string remote_dbname
}
struct CreateDataConnectorRequest {
- 1: DataConnector connector
+ 1: required DataConnector connector
}
struct GetDataConnectorRequest {
1: required string connectorName
}
+struct AlterDataConnectorRequest {
+ 1: required string connectorName,
+ 2: required DataConnector newConnector
+}
+
+struct DropDataConnectorRequest {
+ 1: required string connectorName,
+ 2: optional bool ifNotExists,
+ 3: optional bool checkReferences
Review Comment:
Here the change is about creating a request-based API for the already
existing API (which takes in all the above 3 parameters).
Currently, we don't use this flag. Yeah, your concern is genuine in the
future when we implement this flag.
Issue Time Tracking
-------------------
Worklog Id: (was: 854182)
Time Spent: 5h 50m (was: 5h 40m)
> Deprecate older APIs in the HMS
> -------------------------------
>
> Key: HIVE-26537
> URL: https://issues.apache.org/jira/browse/HIVE-26537
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Critical
> Labels: hive-4.0.0-must, pull-request-available
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> This Jira is to track the clean-up(deprecate older APIs and point the HMS
> client to the newer APIs) work in the hive metastore server.
> More details will be added here soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
