[
https://issues.apache.org/jira/browse/HIVE-26537?focusedWorklogId=854184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854184
]
ASF GitHub Bot logged work on HIVE-26537:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 12:55
Start Date: 31/Mar/23 12:55
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1154441856
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2236,9 +2282,9 @@ struct GetSchemaResponse {
struct GetPartitionRequest {
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
- 4: required list<string> partVals,
+ 2: optional string dbName,
Review Comment:
2 reasons. 1) ease of use in HMSClient 2) Tests are sending null values in
these required values and as a result, the request won't even land on HMS.
But both reasons are defeating the whole objective as these 3 values are
always required. I'll handle the null values in the HMS client and keep these
values as required.
Issue Time Tracking
-------------------
Worklog Id: (was: 854184)
Time Spent: 6h (was: 5h 50m)
> Deprecate older APIs in the HMS
> -------------------------------
>
> Key: HIVE-26537
> URL: https://issues.apache.org/jira/browse/HIVE-26537
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Critical
> Labels: hive-4.0.0-must, pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
> This Jira is to track the clean-up(deprecate older APIs and point the HMS
> client to the newer APIs) work in the hive metastore server.
> More details will be added here soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
