[
https://issues.apache.org/jira/browse/HIVE-27473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937273#comment-17937273
]
Shohei Okumiya commented on HIVE-27473:
---------------------------------------
[~seonggon] Thanks for being involved with this issue. I'm sharing the URL
explaining the three options just for reference to other people.
[https://docs.google.com/document/d/1fFvB0DAXJvPYv27R8nLa3tOUT67-hY0owxBrDY-BxUA/edit?usp=sharing]
> I believe that HIVE-12679 + HIVE-27473 is also a viable approach after a
> quick survey on HiveMetaStoreClient and its subclasses
I assume this is Option 1. Do you think Option 1 can outperform Option 2? If
Option 2 seems to be better, I think we can void HIVE-27473. I am thinking of
asking the community which we should choose.
Option 1 is being dropped mainly because solving the puzzle of the dependencies
is unrealistic. If you can provide a minimal example with createTable and
getTable quickly, the option can be revived.
I am specifically answering your questions.
> Would it be possible for me to take on this issue? Since you are the
> assignee, I will, of course, wait for your work if you are working on it.
Yes! But I guess the community should discuss Option 1 vs Option 2 because we
might not need Option 1 if Option 2 is better for us.
> Do you think the approach I described above is possible? Given your prior
> experience with this issue, I would appreciate any insights you can provide,
> especially if I have overlooked something.
In my memory, it is not easy to make all traits work. I guess the most
economical way is to implement the new APIs that support minimal operations,
i.e., getTable and createTable. I would like to see the new hierarchy.
> Would resolving this issue contribute to HIVE-28658? While I find some
> potential contributions within this JIRA, my ultimate goal is to support
> resolving HIVE-28658. The community will decide whether to proceed with
> Option 1 (+HIVE-27473) or Option 2, but I would like to hear your thoughts on
> whether addressing this issue could contribute to HIVE-12679 and, in turn,
> HIVE-28658.
I think so. HIVE-27473 would resolve HIVE-12679, and then it would resolve
HIVE-28658.
> Make SessionHiveMetaStoreClient and HiveMetaStoreClientWithLocalCache
> composable
> --------------------------------------------------------------------------------
>
> Key: HIVE-27473
> URL: https://issues.apache.org/jira/browse/HIVE-27473
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0-alpha-2
> Reporter: Shohei Okumiya
> Assignee: Shohei Okumiya
> Priority: Major
>
> Currently, we implement the two classes using inheritance. It assumes we
> always use a single implementation of IMetaStoreClient.
> Some community members have been willing to make IMetaStoreClient pluggable
> as proposed in HIVE-12679. Considering the use case, we should provide the
> additional traits with composition over inheritance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
