[
https://issues.apache.org/jira/browse/HIVE-27473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937316#comment-17937316
]
Seonggon Namgung commented on HIVE-27473:
-----------------------------------------
[~okumin] Thank you for your kind response.
> I assume this is Option 1. Do you think Option 1 can outperform Option 2? If
> Option 2 seems to be better, I think we can void HIVE-27473. I am thinking of
> asking the community which we should choose.
I cannot think of any factors that would create a significant performance
difference as of now.
In terms of code maintainability, I believe Option 1 is preferable because
Option 2 would increase the complexity of HiveMetaStoreClient, as it requires
additional code to support both the existing Thrift client and custom clients.
Additionally, if we resolve HIVE-27473, then I think Option 1 and Option 2 will
offer a similar user experience, as Option 1 no longer requires custom clients
to implement session-level features.
> Option 1 is being dropped mainly because solving the puzzle of the
> dependencies is unrealistic. If you can provide a minimal example with
> createTable and getTable quickly, the option can be revived.
I have started writing a sample code to demonstrate the feasibility of
HIVE-27473. I will share the example as soon as possible so we can continue the
discussion about Option 1.
> Make SessionHiveMetaStoreClient and HiveMetaStoreClientWithLocalCache
> composable
> --------------------------------------------------------------------------------
>
> Key: HIVE-27473
> URL: https://issues.apache.org/jira/browse/HIVE-27473
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0-alpha-2
> Reporter: Shohei Okumiya
> Assignee: Shohei Okumiya
> Priority: Major
>
> Currently, we implement the two classes using inheritance. It assumes we
> always use a single implementation of IMetaStoreClient.
> Some community members have been willing to make IMetaStoreClient pluggable
> as proposed in HIVE-12679. Considering the use case, we should provide the
> additional traits with composition over inheritance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
