[ https://issues.apache.org/jira/browse/HIVE-16688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204577#comment-16204577 ]
Hive QA commented on HIVE-16688: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12892082/HIVE-16688.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 11234 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_all_non_partitioned] (batchId=7) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=163) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=110) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_notin] (batchId=133) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_select] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_views] (batchId=108) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query16] (batchId=242) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query94] (batchId=242) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=240) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query16] (batchId=240) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query94] (batchId=240) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=203) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7293/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7293/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7293/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12892082 - PreCommit-HIVE-Build > Make sure Alter Table to set transaction=true acquires X lock > ------------------------------------------------------------- > > Key: HIVE-16688 > URL: https://issues.apache.org/jira/browse/HIVE-16688 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 1.3.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Priority: Critical > Attachments: HIVE-16688.01.patch, HIVE-16688.02.patch > > > suppose we have non-acid table with some data > An insert op starts (long running) (with hive.txn.strict.locking.mode=false > this takes shared lock) > An alter table runs to add (transactional=true) > An update is run which will read the list of "original" files and assign IDs > on the fly which are written to a delta file. > The long running insert completes. > Another update is run which now sees a different set of "original" files and > will (most likely) assign different IDs. > Need to make sure to mutex this -- This message was sent by Atlassian JIRA (v6.4.14#64029)