[ https://issues.apache.org/jira/browse/HIVE-16688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206287#comment-16206287 ]
Eugene Koifman commented on HIVE-16688: --------------------------------------- reran update_all_non_partitioned - looks fine [~alangates] could you review please > Make sure Alter Table to set transaction=true acquires X lock > ------------------------------------------------------------- > > Key: HIVE-16688 > URL: https://issues.apache.org/jira/browse/HIVE-16688 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 1.3.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Priority: Critical > Attachments: HIVE-16688.01.patch, HIVE-16688.02.patch > > > suppose we have non-acid table with some data > An insert op starts (long running) (with hive.txn.strict.locking.mode=false > this takes shared lock) > An alter table runs to add (transactional=true) > An update is run which will read the list of "original" files and assign IDs > on the fly which are written to a delta file. > The long running insert completes. > Another update is run which now sees a different set of "original" files and > will (most likely) assign different IDs. > Need to make sure to mutex this -- This message was sent by Atlassian JIRA (v6.4.14#64029)